fix(a11y): announce skin tone menu state in emoji picker - #19
Merged
Conversation
miluoshi
approved these changes
Nov 14, 2025
kmaraz
marked this pull request as ready for review
November 14, 2025 12:20
daelmaak
reviewed
Nov 14, 2025
ondrasak
approved these changes
Nov 14, 2025
Screen readers couldn’t tell whether the emoji picker’s “Choose default skin tone” toggle was collapsed or expanded, so aria-expanded never changed and there was no spoken feedback. I added state-aware labeling inside Picker.tsx, wiring aria-expanded and the button’s aria-label to reflect the open/closed state and to fall back gracefully if localized strings are missing. To keep the experience consistent in every language, I expanded each locale’s a11y section with translations of “collapsed” and “expanded,” so the new label stays localized across the board.
daelmaak
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen readers couldn’t tell whether the emoji picker’s “Choose default skin tone” toggle was collapsed or expanded, so aria-expanded never changed and there was no spoken feedback. I added state-aware labeling inside Picker.tsx, wiring aria-expanded and the button’s aria-label to reflect the open/closed state and to fall back gracefully if localized strings are missing. To keep the experience consistent in every language, I expanded each locale’s a11y section with translations of “collapsed” and “expanded,” so the new label stays localized across the board.